Revision history [back]
Done a while ago, a page name is added to the class at most pages (but not all yet - only those that required that for the styling).
For example, main page has class "main-page", also multiple classes are used everywhere, at the expense of not supporting IE6, which is almost extinct by now.
Also, added a document on skin customization: http://askbot.org/doc/customizing-skin-in-askbot.html
Done a while ago, a page name is added to the class at most pages (but not all yet - only those that required that for the styling).
For example, main page has class "main-page", also multiple classes are used everywhere, at the expense of not supporting IE6, which is almost extinct by now.
Also, added a document on skin customization: http://askbot.org/doc/customizing-skin-in-askbot.html
Done Pekka, I thought about this one for a while ago, a page name is added to the and can't find a big benefit for us - maybe I am missing something again, which I easily might. What you are asking is very easy to add though.
So, suppose you have a list of questions, why not just mark it up like:
<ul class="abQList">
</ul>
That way markup is explicit and clear enough.
What you propose is useful in the cases where you want to style say question title differently in one view vs another and it allows using "cascading" property of stylesheets and minimizes size of css.
We do have one place like that - question list is styled differently in the user profile view - so there is another class at most pages (but for that - I don't know of others.
Maybe we should instead start marking up (with id and class names) important elements? and freeze those names? I'll post a separate question about it.
If you are working on cusom skin now - why don't we try to work in sync? I can make necessary changes to the default skin and you can perhaps somehow use those in your project? (At the same time - please do not all yet - only those that required that for the styling).
For example, main page has class "main-page", also multiple classes are used everywhere, at the expense of not supporting IE6, which is almost extinct by now.
hesitate to just commit to to github)Pekka, I thought about this one for a while and can't find a big benefit for us - maybe I am missing something again, which I easily might. What you are asking is very easy to add though.might.
So, suppose you have a list of questions, why not just mark it up like:
<ul class="abQList">
</ul>
That way markup is explicit and clear enough.
What you propose is useful in the cases where you want to style say question title differently in one view vs another and it allows using "cascading" property of stylesheets and minimizes size of css.
We do have one place like that - question list is styled differently in the user profile view - so there is another class for that - I don't know of others.
Also - we should think of how we find elements with javascript. IMO using descendant selectors (something inside something, etc.) is not very good if we want to make skins more maintainable.
Maybe we should instead start marking up (with id and class names) important elements? and freeze those names? I'll post a separate question about it.
If you are working on cusom skin now - why don't we try to work in sync? I can make necessary changes to the default skin and you can perhaps somehow use those in your project? (At the same time - please do not hesitate to just commit to to github)
Pekka, I thought about this one for a while and can't find a big benefit for us - maybe I am missing something again, which I easily might.again :). (Although it will be very easy to add).
So, suppose you have a list of questions, why not just mark it up like:
<ul class="abQList">
</ul>
That way markup is explicit and clear enough.
What you propose is useful in the cases where you want to style say question title differently in one view vs another and it allows using "cascading" property of stylesheets and minimizes size of css.
We do have one place like that - question list is styled differently in the user profile view - so there is another class for that - I don't know of others.
Also - we should think of how we find elements with javascript. IMO using descendant selectors (something inside something, etc.) is not very good if we want to make skins more maintainable.
Maybe we should instead start marking up (with id and class names) important elements? and freeze those names? I'll post a separate question about it.
If you are working on cusom skin now - why don't we try to work in sync? I can make necessary changes to the default skin and you can perhaps somehow use those in your project? (At the same time - please do not hesitate to just commit to to github)
Pekka, I thought about this one for a while and can't find a big benefit for us - maybe I am missing something again :). (Although it will be very easy to add).
So, suppose you have a list of questions, why not just mark it up like:
<ul class="abQList">
</ul>
That way markup is explicit and clear enough.
What you propose is useful in the cases where you want to style say question title differently in one view vs another and it allows using "cascading" property of stylesheets and minimizes size of css.
We do have one place like that - question list is styled differently in the user profile view - so there is another class for that - I don't know of others.
Also - we should think of how we find elements with javascript. IMO using descendant selectors (something inside something, etc.) is not very good if we want to make skins more maintainable.
Maybe we should instead start marking up (with id and class names) important elements? and freeze those names? I'll post a separate question about it.
If you are working on cusom skin now - why don't we try to work in sync? I can make necessary changes to the default skin and you can perhaps somehow use those in your project? (At the same time - please do not hesitate to just commit to to github)