Revision history  [back]

Tyler you are right to point this out, we should pay more attention to that. We will try to merge some requests soon.

A common problem with the pull requests is a lack of test cases, which makes it more difficult to integrate them.

edit 2 Roughly, we apply the following rules to accepting the pull requests:

• Obvious bug fixes are accepted instantly
• Translation contributions will no longer be accepted via github - please use [Transifex].(https://www.transifex.com/projects/p/askbot/)
• If a pull request contains a new feature - I cannot guarantee merging without accepting the feature itself - regardless of the implementation. Please, let's discuss new features first.
• More than one feature per pull request makes it less likely that for us to merge, which means - please use one topic branch per feature - forked directly from the Askbot's master branch.merge.
• New features must be implemented to decent quality and must be covered by test cases.
• All existing test cases must pass in the pull request.

edit 1: it is true - we do not have any organization for the development, neither a roadmap, nor a process. I agree that it makes it more difficult for others to contribute.

Tyler you are right to point this out, we should pay more attention to that. We will try to merge some requests soon.

A common problem with the pull requests is a lack of test cases, which makes it more difficult to integrate them.

edit 2 Roughly, we apply the following rules to accepting the pull requests:

• Obvious bug fixes are accepted instantly
• Translation contributions will no longer be accepted via github - please use [Transifex].(https://www.transifex.com/projects/p/askbot/)
• If a pull request contains a new feature - I cannot guarantee merging without accepting the feature itself - regardless of the implementation. Please, let's discuss new features first.implementation.
• More than one feature per pull request makes it less likely that for us to merge.
• New features must be implemented to decent quality and must be covered by test cases.
• All existing test cases must pass in the pull request.

edit 1: it is true - we do not have any organization for the development, neither a roadmap, nor a process. I agree that it makes it more difficult for others to contribute.

Tyler you are right to point this out, we should pay more attention to that. We will try to merge some requests soon.

A common problem with the pull requests is a lack of test cases, which makes it more difficult to integrate them.

edit 2 Roughly, we apply the following rules to accepting the pull requests:

• Obvious bug fixes are accepted instantly
• Translation contributions will no longer be accepted via github - please use [Transifex].(https://www.transifex.com/projects/p/askbot/)
• If a pull request contains a new feature - I cannot guarantee merging without accepting the feature itself - regardless of the implementation.
• More than one feature per pull request makes it less likely that for us to merge.
• New features must be implemented to decent quality and must be covered by test cases.
• All existing test cases must pass in the pull request.

edit 1:edit: it is true - we do not have any organization for the development, neither a roadmap, nor a process. I agree that it makes it more difficult for others to contribute.

Tyler you are right to point this out, we should pay more attention to that. We will try to merge some requests soon.

A common problem with the pull requests is a lack of test cases, which makes it more difficult to integrate them.