Gravatar Hashes having an extra 's'

image
fixed
gravatar
bug
retag add tags

Hi,

I've noticed gravatar hashes get an extra 's' after the actual hash. It seems to be because of the code in in askbot-0.6.65-py2.6.egg\askbot\templatetags\extra_tags.py@L16 which should be:

                     'src="http://www.gravatar.com/avatar/%(gravatar_hash)'

instead of

                     'src="http://www.gravatar.com/avatar/%(gravatar_hash)s'

As of now, it prevents me from getting my actual updated gravatar image. Is it a typo or is it normal?

As a side note.. I've changed the aforementionned file code, removed all PYC files in askbot directory, restarted the web server and emptied my browser cache but, still, it does not fix it. What am I doing wrong? (Sorry, first time with Django!)

Thanks for your time and consideration!

Ben

13.2k

Evgeny

updated 2011-02-03 16:59:45 -0600

Ben

asked 2011-01-31 16:13:57 -0600

edit flag offensive 0 remove flag close merge delete

Comments

retagged as bug again, will remove this issue in the next release (I make them often, sometimes more than once a week). I've edited out the issue on this site, since it was a matter of just deleting a character.

Evgeny (2011-01-31 16:43:43 -0600) edit

add a comment see more comments

3 Answers

Sort by

oldest

newest

most voted

Right on, Evgeny. There is indeed a cache issue here.

Still, all pictures hashes end with the 's' character. Right on this question page, for instance, your gravatar picture URI is:

http://www.gravatar.com/avatar/db77fe6f52095bd53cbd53a406e2c4b2s?s=32&d=identicon&r=PG

whereas

http://www.gravatar.com/avatar/db77fe6f52095bd53cbd53a406e2c4b2?s=32&d=identicon&r=PG

would work (better?)

For instance, take a look at mine:

http://www.gravatar.com/avatar/4d8dff2584ac29510f092808ea3afee5s?s=128&d=identicon&r=PG

returns a different picture than

http://www.gravatar.com/avatar/4d8dff2584ac29510f092808ea3afee5?s=128&d=identicon&r=PG

Edit: I read Python docs, and while I completely agree with you and the documentation, I do not get why the results are what they are... this is disturbing. Anyway, as you mentionned, the gravatar images are getting updated so it's not very important. :-)

Thanks for your time anyway!

Ben

updated 2011-01-31 16:34:34 -0600, answered 2011-01-31 16:30:44 -0600

edit flag offensive 0 remove flag delete link

Comments

add a comment see more comments

Ben, I think that your gravatar change has not yet propagated through various caches, there is no problem with retrieving the images as you can see on this site.

the extra "s" is a formatting character for a string substitution, it is necessary to recognize the "gravatar_hash" variable as string and insert the value into the url.

Here are python docs on string formatting.

edit actually you are right, the gravatars have an extra s that does not belong there, but apparently it has no effect. Looks like you've discovered a "gravatar law". In fact it does not change if you append more characters.

The extra "s" comes from a template macro "gravatar" in file askbot/skins/default/templates/macros.html. The code that you've mentioned is not in use now, will eventually be removed.

13.2k

Evgeny

updated 2011-01-31 16:48:01 -0600, answered 2011-01-31 16:20:01 -0600