First time here? Check out the FAQ!
Ask Your Question
1

fixing the tarball

LICENSE should be in the base directory. Not a subdirectory.

zero length files should all be removed:

doc/build/html/.buildinfo skins/default/media/images/flags/.DS_Store deps/livesettings/locale/es/LC_MESSAGES/django.po version.* setup_templates/log/askbot.log doc/build/html/.buildinfo

executable bit should be removed form these files:

skins/README setup_templates/upfiles/README views/README skins/default/media/js/wmd/.js skins/default/media/js/.bat skins/default/media/style/*.css skins/default/media/jquery-openid/openid.css skins/default/media/js/wmd/wmd-test.html skins/default/media/jquery-openid/jquery.openid.js skins/default/media/js/wmd/wmd.css

shebang from these files:

utils/diff.py setup_templates/manage.py bin/show_profile_stats.py bin/generate_modules.py cron/askbot_cron_job

bin/rmpyc -> can go into /usr/bin but could be renamed to askbot-rmpyc or something more likely to avoid namespace clashes and easily to locate. As a reminder, startforum can be renamed to askbot-setupforum

When extracting the tarball, I also get:

tar: Ignoring unknown extended header keyword SCHILY.dev' tar: Ignoring unknown extended header keywordSCHILY.ino' tar: Ignoring unknown extended header keyword `SCHILY.nlink

Evgeny's avatar
13.2k
Evgeny
updated 2011-08-03 13:55:53 -0600
mether's avatar
1.5k
mether
asked 2011-08-03 11:53:09 -0600
edit flag offensive 0 remove flag close merge delete

Comments

Sorry, which tarball are you talking about? - I don't see that message anywhere.
Evgeny's avatar Evgeny (2011-08-03 13:51:13 -0600) edit
more
  • delete
Renamed startforum to askbot-setup.
Evgeny's avatar Evgeny (2011-08-04 09:17:25 -0600) edit
more
  • delete
add a comment see more comments

1 Answer

1

Removed blank files, added ignore to askbot/doc/build, removed most of hashbangs, removed some of the script files that you pointed out as I thought they were not so important.

Left one '#!' in manage.py - this file comes with django and added as is, without changes.

This is available in the latest git commit.

Evgeny's avatar
13.2k
Evgeny
updated 2011-08-03 13:55:31 -0600, answered 2011-08-03 13:54:05 -0600
edit flag offensive 0 remove flag delete link
more

Comments

Thank you. Can you move the LICENSE file to the base dir? That's the usual location for it.
mether's avatar mether (2011-08-03 14:08:24 -0600) edit
more
  • delete
Done in the repo, will add to the next mini-release.
Evgeny's avatar Evgeny (2011-08-03 14:11:11 -0600) edit
more
  • delete
That's great. I will pull in it when it's released
mether's avatar mether (2011-08-03 14:18:49 -0600) edit
more
  • delete
Few more things. The (c) info on top of the file is outdated. Since you already have a AUTHORS file, this is just misleading. You might want to replace this file entirely with the actual copy of GPLv3. GPLv3 actually mandates this. Also you might want to move AUTHORS, ROADMAP.rst, TODO.rst, WISH_LIST to the base after verifying it is current. ROADMAP.rst has a couple of typos as well "Aksbot" "Bacic" is what I noticed. Can't hurt to run a spell checker on all the text files.
mether's avatar mether (2011-08-03 14:25:07 -0600) edit
more
  • delete
Added the AUTHORS file to root, removed TODO.rst, and WISH_LIST, moved ROADMAP.rst to documentation source. Updated the copyright message - it will stay as is. I did look at GPL and found that use of the license does not require giving up copyright. The license message is formatted in a way recommended here: http://www.gnu.org/copyleft/gpl.html, so I think we are fine here.
Evgeny's avatar Evgeny (2011-08-03 17:33:09 -0600) edit
more
  • delete
add a comment see more comments