status of bundled dependencies?

roadmap
retag add tags

Askbot has a few bundled dependencies. From a Linux distribution perspective, we prefer unbundling and packaging them separately to make it reusable across applications. More details here

Going through the dependencies in deps/, I see the following

grapefruit.py - Seems to just a copy from from https://code.google.com/p/grapefruit/. License: Apache v2. I intend to package this separately and remove the bundled copy.
django_authopenid - Forked version from upstream. Intended to be phased out. When and why? Upstream at https://bitbucket.org/benoitc/django-authopenid/wiki/Home. Seems inactive. License: Apache v2. Forked copy has no license indication however. Needs to be fixed.
openid - No README file. Is this forked? What is the upstream? License status unknown. Needs to be fixed.
livesettings - Forked version of django-livesettings. Status of merge back? Upstream at https://bitbucket.org/bkroeze/django-livesettings. License: New BSD. Upstream includes a copy of the license. Bundled fork does not. Needs to be fixed
recaptcha_django - Seems to be just a copy from https://code.google.com/p/recaptcha-django/. License: New BSD. I intend to package this separately and remove the bundled copy.

Do let me know your thoughts

1.5k

mether

updated 2011-07-31 23:57:22 -0600, asked 2011-06-26 20:30:08 -0600

edit flag offensive 0 remove flag close merge delete

Comments

Just a quick update. Grapefruit and Django recaptcha has been packaged. https://bugzilla.redhat.com/show_bug.cgi?id=716808 and https://bugzilla.redhat.com/show_bug.cgi?id=716844. Waiting on more info for dealing with the rest

mether (2011-06-27 05:11:49 -0600) edit

openid seems to be a copy of python-openid module. Is this forked or just a copy?

mether (2011-07-15 22:08:54 -0600) edit

@evgeny, I could really use some help here. Also I am very close to running a test instance of askbot in Fedora and a couple of questions about db migration need answers http://lists.fedoraproject.org/pipermail/infrastructure/2011-July/010599.html

mether (2011-07-21 23:16:37 -0600) edit

At one point python-openid module just would not install from the python package index due to bad url, so I just bundled it. Right now it is not a problem, so it can be removed. I will do it now actually, if I don't break anything, will publish the code immediately, otherwise - on Saturday.

Evgeny (2011-07-21 23:26:04 -0600) edit

Thanks. For the forked versions of django_authopen and livesettings, if it is not getting merged upstream and there are no plans, it would be better to rename it and put it up as a separate module in pypi IMO. This makes it possible for other projects to reuse it if necessary rather than bundling it hidden inside askbot. It is a bit more additional work for me but I can handle that. Any thoughts on the db questions in the Fedora infrastructure mailing list? Thank you as always for your quick responses

mether (2011-07-21 23:31:34 -0600) edit

add a comment see more comments

3 Answers

Sort by

oldest

newest

most voted

Javascript library bundling:

Just noticed that you are also bundling jquery and a few extensions to that, wmd and yuicompressor jar file. I understand the former 2 being used at runtime but is yuicompressor being used at all at runtime? Can I remove it from the package?

1.5k

mether

answered 2011-07-24 10:34:48 -0600

edit flag offensive 0 remove flag delete link

Comments

yui compressor can be just deleted., but others probably not. The reason is that there isn't a way I know of to package js components with python packages. In most cases askbot is installed via pip - from the python package index... Also, for jquery we need a specific version, wmd is forked - to support i18n, and file attachments.

Evgeny (2011-07-24 11:39:48 -0600) edit

test site at http://ask01.dev.fedoraproject.org:8888/questions/

mether (2011-07-24 12:23:04 -0600) edit

Very nice. Please give your feedback on how it works for you. I notice that there are many users with the same gravatar - are all those test accounts? Are you using the same email address for them?

Evgeny (2011-07-24 13:30:51 -0600) edit

Nope. Different accounts. Potentially they all use the Fedora auth plugin. Code for that is at https://github.com/pjps/fasauth/. When you have time, could you setup a #askbot irc channel? I need some help in setting up memcached and it is easier to talk and fix issues in real time. If you need admin access to the box, I can get you that

mether (2011-07-24 13:37:33 -0600) edit

Hi Rahul, OK, maybe tomorrow you'll give me the login credentials by skype (evgeny-fadeev), I'll take a look at the avatar problem. I'll be at the irc too.

Evgeny (2011-07-24 23:36:22 -0600) edit

add a comment see more comments

grapefruit - removed

Django_openid - bundled but can be disabled, it is really a fork and at this point it is part of askbot because it imports some things from askbot. If you disable django_openid application - a replacement authentication module must be installed.

Python-openid - removed

Recaptcha-django - removed and replaced with "django-recaptcha-works" in dependencies.

Livesettings - slightly forked, need to talk to the satchmo bosses (livesettings is taken from the satchmo online store software) to see if they are interested in merging my changes.

edit two forked modules left at the moment - django_authopenid and livesettings.

Do you need all these resolved before you can complete the Fedora .rpm?

13.2k

Evgeny

updated 2011-07-31 16:38:30 -0600, answered 2011-07-21 23:37:40 -0600

edit flag offensive 0 remove flag delete link

Comments

I can get a exception request but this will stall the process quite a bit because Fedora is fairly strict about this - > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions If you cleanup any bundled dependencies as much as possible and do a release, that would be really helpful. I have done a preliminary build of askbot in the development branch of Fedora but for the testing and production deployment, we would like this to be resolved

mether (2011-07-21 23:45:32 -0600) edit

Well, I'll take this for the weekend. Unfortunately tomorrow I will be away all day, but will work on Saturday and Sunday.

Evgeny (2011-07-21 23:50:21 -0600) edit

Alright. Thanks. Appreciate the help

mether (2011-07-21 23:54:46 -0600) edit

technically I now removed the recaptcha-django, now need to try to get the official module upgraded, if this does not happen by the end of the week, I'll make it into django-recaptcha2.

Evgeny (2011-07-27 10:56:50 -0600) edit

I am looking at 0.7.9 and I see three modules still left. The documentation seems to have contain a number of references to grapefruit and so on. You might want to update the bundled docs although this is low priority from my perspective

mether (2011-07-31 10:37:08 -0600) edit

add a comment see more comments

Can I know the current status of the couple of remaining bundled modules?

1.5k

mether

answered 2011-08-28 02:13:54 -0600

edit flag offensive 0 remove flag delete link

Comments

I think about a week of work left. I've almost finished removal of django-authopenid (just updated the code) on the separate branch, hope to finish tomorrow. I need to package several modules that were removed as well from askbot so that they could be shared by the authenticator app and askbot. After this is done - the live settings will be left, which is easier to remove. I've been in Russia last two weeks and unfortunately did not have as much time as I wanted for the coding.

Evgeny (2011-08-28 02:28:43 -0600) edit

I notice that style of the comments changed - we'll try to fix this next week, comments are now rendered slightly differently.

Evgeny (2011-08-28 02:30:01 -0600) edit

add a comment see more comments

status of bundled dependencies? edit

Comments

3 Answers

Comments

Comments

Comments

status of bundled dependencies?