ReferenceError: Can't find variable: share_url in post.js:1573
Tried a quick iframe in a js pop-up implementation - does not work for facebook.
Turns out there is an HTTP header that you can use to forbid displaying your site in iframes - which apparently facebook does - so apparently the only options are: pop up window and replace the view in the current window.
Would be nice to be able to detect when pop-ups are blocked and then go for the second option as a fallback.
After looking at post.js a bit more it seems as the fallback is already implemented, but buggy: If the pop up window fails, it is tried to open the link in the current window, but the wrong variable is used.
After looking at post.js a bit more it seems as the fallback is already implemented, but buggy: If the pop up window fails, it is tried to open the link in the current window, but the wrong variable is used.
Detection of blocked pop-ups and fallback to open the link in the current window is now fixed in https://github.com/ASKBOT/askbot-devel/commit/d39849bc2e73d1c9cdcb07b12fe6fdf6d562e582">git.
Comments
I did not see the error in the console, but obviously if you block the pop-ups - they won't open. Current implementation uses pop-up windows - so it is perhaps a misfeature. A js-popup would be nicer, we'll look into that.
Just looked at post.js myself: If you change the name of share_url to url, the sharing page opens in the current window if the popup cannot be opened.
Hmm, did not think of that, I am not sure I like that a whole page from another site will take entire screen. I really prefer a js popup.
Yes, a popup is indeed preferable... perhaps informing the user that the popup could not be opened, as clicking on the sharing buttons and nothing happens is bad behavior, I think.